chore: track installer/macos/dist/Daemora.pkg#80
Merged
Merged
Conversation
The global `dist/` rule in .gitignore was catching the macOS installer output dir, but the Windows side already commits its installer binary (installer/windows/Output/DaemoraSetup.exe). Add an explicit !exception for installer/macos/dist/** so the .pkg ships in the repo too. Until we set up GitHub Releases as the canonical distribution channel, both installers live next to source — non-tech users grab them directly from the GitHub web UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single commit on dev that didn't make PR #79's window — adds an explicit `.gitignore` exception for `installer/macos/dist/**` and commits the built `Daemora.pkg` (554 KB) so non-technical users can download it directly from the GitHub file tree until we set up Releases.
This matches the existing Windows convention — `installer/windows/Output/DaemoraSetup.exe` is already tracked. The macOS dist dir was unintentionally caught by the global `dist/` ignore rule.
Test plan