Implement CCCChange Checker #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
changed the title
majecty
force-pushed
the
f/cccChangeChecker
branch
from
2764262 to
4c0172b
Compare
majecty
changed the title
majecty
force-pushed
the
f/cccChangeChecker
branch
from
4c0172b to
9a75372
Compare
majecty
force-pushed
the
f/cccChangeChecker
branch
from
9a75372 to
a238122
Compare
After supporting dynamic validator, Solo and PoW cases were not handled correctly.
majecty
force-pushed
the
f/cccChangeChecker
branch
from
a238122 to
6ef645d
Compare
joojis
reviewed
Jul 10, 2019
| }); | ||
| context.worker.run(); | ||
|
|
||
| if (process.env.ENABLE_CCC_CHANGES_CHECK) { |
Contributor
There was a problem hiding this comment.
Would you add it to README?
ScarletBlue
suggested changes
Jul 11, 2019
README.md
Outdated
|
|
||
| If you run the Indexer with the environment `ENABLE_CCC_CHANGES_CHECK` variable, | ||
| the Indexer checks to see if CCCChanges is well calculated. | ||
| If you want to receive an email when an error is found, please set `SENDGRID_API_KEY` and `SENDGRID_TO` variables. |
There was a problem hiding this comment.
If you want to receive an email when an error is found, please set the SENDGRID_API_KEY and SENDGRID_TO variables.
README.md
Outdated
| If you run the Indexer with the environment `ENABLE_CCC_CHANGES_CHECK` variable, | ||
| the Indexer checks to see if CCCChanges is well calculated. | ||
| If you want to receive an email when an error is found, please set `SENDGRID_API_KEY` and `SENDGRID_TO` variables. | ||
| If you want to receive a slack notification, please set `SLACK_WEBHOOK` variable. |
There was a problem hiding this comment.
If you want to receive a slack notification, please set the SLACK_WEBHOOK variable.
majecty
force-pushed
the
f/cccChangeChecker
branch
from
22703e0 to
b574114
Compare
Contributor
Author
|
@ScarletBlue I fixed them. |
ScarletBlue
approved these changes
Jul 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #279.
This PR closes #274