Skip to content

Conversation

@joojis
Copy link
Contributor

@joojis joojis commented Nov 12, 2018

Will resolve #245.

Remaining:

  • Asset
  • AssetScheme
  • Block
  • AssetComposeTransaction
  • AssetDecomposeTransaction
  • Action
    • Payment
    • SetRegularKey
    • CreateShard
    • SetShardOwners
    • SetShardUsers

@joojis joojis force-pushed the json-type branch 3 times, most recently from 0276ef9 to ec382fb Compare November 12, 2018 05:45
This patch also fixes:
- A bug in fromJSON() of AssetDecomposeTransaction.
- Use of U256.toEncodeObject() in toJSON() to use U256.toString() with 0x prefix.
@joojis joojis changed the title [WIP] Add type declarations for toJSON() and fromJSON() Add type declarations for toJSON() and fromJSON() Nov 12, 2018
@joojis joojis merged commit fcf038e into CodeChain-io:master Nov 12, 2018
@joojis joojis deleted the json-type branch November 12, 2018 06:04
@joojis joojis mentioned this pull request Nov 12, 2018
3 tasks
@joojis
Copy link
Contributor Author

joojis commented Nov 12, 2018

I merged it because some bug fixes need to be published.
The left items are moved to the issue: #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some type declarations are wrong.

1 participant