Upgrade rust toolchains #1953
Merged
Upgrade rust toolchains #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Codechain uses fixed-hash@0.2.1v that has a duplicated macro definition. The duplicated macro makes the latest clippy(+nightly-2019-12-19) fail. So, we need to upgrade it. When fixed-hash 0.2.5 was applied, an error(E0599) occurred due to incompatibility for some functions. This problem can be solved as follows. 1. Upgrade Our rust-codechain-primitives(`primtivies`) to use the upgraded fixed-hash. 2. Upgrade libraries using `primitives` used by CodeChain and modules in CodeChain. However, too many libraries(rlp, rust-codechain-crypto etc) are using `primitives` that are not updated. Also, this is not a problem that will be solved just by upgrading primitives. We need a large-scale update to use fixed-hash@≥0.2.5 and later version of some packages. Fortunately, we checked 0.2.2 had resolved the macro duplication problem. We thought it's best to upgrade to 0.2.2 under the current situation. Fixed #1938
Contributor
Author
|
@sgkim126 If it is fine, I will apply it to foundry too. |
Currently, Codechain uses the clippy(+nightly-2019-11-06) and the rustfmt(+nightly-2019-11-06). We need to make codechain use the latest toolchains. I upgraded the clippy to `+nightly-2019-12-19` and the rustfmt to `+nigtly-2019-12-19`. Fixed #1937
majecty
requested changes
Jan 8, 2020
Contributor
|
Could you rebase the branch on the master? |
sgkim126
approved these changes
Jan 9, 2020
majecty
approved these changes
Jan 9, 2020
Contributor
|
@somniumism Could you apply this in Foundry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Codechain uses the clippy(+nightly-2019-11-06) and the rustfmt(+nightly-2019-11-06).
We need to make codechain use the latest toolchains.
I upgraded the clippy to
+nightly-2019-12-19and the rustfmt to+nigtly-2019-12-19.I fixed clippy error occurred from new clippy version. The warning is this;
clippy waring:using tabs in doc comments is not recommendedFix #1937