Skip to content

Conversation

@Tanner-Scadden
Copy link
Member

@Tanner-Scadden Tanner-Scadden commented Aug 11, 2024

The Pull Request is ready

  • all github actions are passing
  • only a single issue was worked on
  • fixes CLI: Issues running cli start #124
  • the branch follows the naming schema issue-123-enable-x-does-not-disable-y
  • the pull request has a sensible title

Intention

With this change I intend to...

  • With @rphovley's recent changes it all worked great for me.
  • Updated it to access the name properly on install to avoid logging out undefined installed.

Review Points

Please take extra care reviewing...

The code follows best practices

  • duplicate code has been extracted where possible
  • issues for follow-up tasks have been created
  • tests have been written for any new functionality
  • there is no any type used
  • texts have been checked for grammar and spelling issues

Notes

@Tanner-Scadden Tanner-Scadden self-assigned this Aug 11, 2024
@Tanner-Scadden
Copy link
Member Author

Building on this, it says it is from an "unidentified developer." I looked into how we could get it done to show codeclimbers and could follow this guide. We need an apple developer account. Can be split up into another ticket, not a big prio imo

https://claude.site/artifacts/d4a7285b-627a-4dde-8fe5-0cfb3f9cf315

@rphovley rphovley merged commit 418f9d3 into main Aug 11, 2024
@rphovley rphovley deleted the issue-124-macos-start branch August 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: Issues running cli start

3 participants