bash/ps1 scripts enhancements/fixes#5
Merged
Conversation
- Fix: Ensure bash EOL is `LF` and not `CRLF` - Fix Apply fixes reported by shellcheck - Check if target exists before creating a directory. This should not be necessary, but i had some random occourrence where the installation was failing because directories/mounts already exists and this seems to have solved the issue. - Add some volume mapping to cache known build artifacts to speed up local builds (`build.ps1`)
D3-LucaPiombino
changed the title
D3-LucaPiombino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
LFand notCRLFbuild.ps1)