Password recovery #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObsessiveOrange
requested changes
Nov 8, 2016
| ) | ||
|
|
||
| var ( | ||
| password = flag.String("password", "password", "Prefix for all Docker images and volumes") |
Member
There was a problem hiding this comment.
I'm assuming the description on this flag is wrong?
| password = &inferred | ||
| } | ||
|
|
||
| fmt.Printf("generating hash for password %s: \n", string(*password)) |
Member
There was a problem hiding this comment.
Er.... should we be printing out the password?
Member
Author
There was a problem hiding this comment.
I don't think it matters. it's a good check that we didn't make a mistake when inputting it. It's going to be on the line above this in the terminal anyways
ObsessiveOrange
approved these changes
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a quick script which generates the password. I figured it's not a great idea to programmatically have something to then place the password in mysql because that requires us to either expose that kind of functionality in a stored procedure or to expose the admin account in the server info.