Sync hotfix #43
Merged
Sync hotfix #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
julie-is-late
requested changes
Dec 21, 2016
modules/dbfs/couchbase.go
Outdated
| if startIndex < 0 { | ||
| return nil, -1, nil, ErrVersionOutOfDate | ||
| } | ||
| // If it's negative at this point, it means startIndex was negative. |
Member
There was a problem hiding this comment.
i'm guessing this isn't actually what you wanted this comment to say? that's obvious, lol, but why is it negative?
Member
Author
There was a problem hiding this comment.
yep. I'll edit that
julie-is-late
approved these changes
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.