Fix lint failures on nightly, don't run nightly on PRs#48
Merged
mkj merged 4 commits intoCodeConstruct:mainfrom May 4, 2026
Merged
Fix lint failures on nightly, don't run nightly on PRs#48mkj merged 4 commits intoCodeConstruct:mainfrom
mkj merged 4 commits intoCodeConstruct:mainfrom
Conversation
collapsible_match was extended to cover if statements. The existing code intent is clearer than with collapsed statements, so disable the check. clippy changed in rust-lang/rust-clippy#16560 Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Reported by newer clippy Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
{:#02x} format unexpectedly doesn't produce width 2.
Instead use a manual 0x{:02x}. Reported by newer clippy.
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Rust nightly may fail for spurious reasons or new clippy lints. Move the nightly version to a separate workflow that runs on a timer so that it doesn't create noise for PRs. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust nightly job has been failing in PRs since some new lints were added.
Resolve those lints, and instead run the nightly PR in a cronjob so that we (maintainers) can see the problems without it being noise in PRs.