mctp-bench: Support recv requests#100
Merged
jk-ozlabs merged 1 commit intoCodeConstruct:mainfrom Jul 31, 2025
Merged
Conversation
Member
|
PR #100 ! 🎉 |
jk-ozlabs
reviewed
Jul 31, 2025
Member
jk-ozlabs
left a comment
jk-ozlabs
left a comment
There was a problem hiding this comment.
Couple of comments inline, but looks good in general.
| static const uint8_t COMMAND_VERSION = 1; | ||
|
|
||
| enum command { | ||
| COMMAND_RESPONSE = 0x00, |
Member
There was a problem hiding this comment.
Will responses to all (future) commands use the same opcode?
(I assume the IID will let us catch mismatched responses, but would a request-specific-response type help to diagnnose?)
Member
Author
There was a problem hiding this comment.
I was intending to use COMMAND_RESPONSE for all, given IID should be reliable.
"mctp-bench recv" can now optionally request that a peer start sending with a specified message count and message length. "mctp-bench recv eid 20 len 987 count 10000" The send equivalent is not yet implemented. Currently mctp-bench will continue listening forever, since it won't necessarily know that all packets have been received (if drops occur). That could be changed in future. With default arguments "mctp-bench recv" behaviour is unchanged. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
mkj
force-pushed
the
dev/bench-receive-request
branch
from
9f15500 to
bfbbb34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"mctp-bench recv" can now optionally request that a peer start sending with a specified message count and message length.
"mctp-bench recv eid 20 len 987 count 10000"
The send equivalent is not yet implemented. Currently mctp-bench will continue listening forever, since it won't necessarily know that all packets have been received (if drops occur). That could be changed in future.
With default arguments "mctp-bench recv" behaviour is unchanged.