Transfer project navigator#1208
Transfer project navigator#1208austincondiff merged 12 commits intoCodeEditApp:refactor/workspace-clientfrom
Conversation
KaiTheRedNinja
requested review from
0xWDG,
Wouter01,
austincondiff,
lukepistrol and
matthijseikelenboom
KaiTheRedNinja
changed the title
Wouter01
left a comment
Wouter01
left a comment
There was a problem hiding this comment.
It seems like the folder icons got a darker shade of blue. I'm assuming this is a bug?
For all the other things: great work!
I believe this is because of the fact that AE uses the accent color of the system. |
|
I could reduce the saturation by about 50% |
matthijseikelenboom
left a comment
matthijseikelenboom
left a comment
There was a problem hiding this comment.
Some of the files have comments at the top with AuroraEditor in it
|
@KaiTheRedNinja Nice work! Yeah, don’t change the saturation, we were using the The project root folder icon uses the |
|
@KaiTheRedNinja were you ever able to make those recommended changes? Where are we with this? |
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
In CodeEdit...
Deleting a file
Deleting a folder
The wording might need to change here. For reference, here is Xcodes...
Deleting a file
Deleting a folder
Maybe something like:
Do you want to move [file or folder name] to the Trash?
This operation cannot be undone.
[ Move to Trash ]
[ Cancel ]
Also, the bottom filter text field does not work. Is this expected from this PR?
|
Yes, the bottom filter is not expected to work. AE's implementation is extremely buggy since it entails saving the outlineview's expansion states. |
|
This may be out of scope but there is a few UI tweaks that could be made
|
|
By eyeballing it, it looks like all the items are in about the right position. |
* Transfer project navigator bottom * Transfer TableViewCell abstractions * Transfer over project manager outline view * Get proj navigator sidebar working again * Rename OutlineView -> ProjectNavigatorOutlineView for clarity * Remove debug statements * Fix incorrect comment headers * Change old AE assets to new CE assets * Add vscode-style toolbar * Disable vertical sidebar by default * Make deletion messages more descriptive * Fix table view cell alignments
* 🧹 Refactor of the WorkspaceClient (#1157) * Transfer project navigator (#1208) * Transfer project navigator bottom * Transfer TableViewCell abstractions * Transfer over project manager outline view * Get proj navigator sidebar working again * Rename OutlineView -> ProjectNavigatorOutlineView for clarity * Remove debug statements * Fix incorrect comment headers * Change old AE assets to new CE assets * Add vscode-style toolbar * Disable vertical sidebar by default * Make deletion messages more descriptive * Fix table view cell alignments * Swiftlint fixes and code clean up * Test fixes --------- Co-authored-by: KaiTheRedNinja <88234730+KaiTheRedNinja@users.noreply.github.com>
6 participants
Description
Transfers the Project Navigator from AuroraEditor over to CodeEdit, making use of the revamped WorkspaceClient
The following sidebar features still need implementation (for future PRs):
This PR also removes the
fileItemsproperty of WorkspaceDocument, as it is now redundant.Related Issues
Checklist
Project Navigator bottom toolbar
Outline View abstractions
Project navigator outline view fixes to get
Rename OutlineView -> ProjectNavigatorOutlineView for clarity
I read and understood the contributing guide as well as the code of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code
Screenshots
Does not modify UI or behaviour, functionally similar to main branch.