Fixed error adding new file or folder from the outline menu

[armartinez]

Description

This PR fixes the error where adding a new folder or file from the outline menu didn't reflect on the outline itself.

Related Issues

• 🐞 Missing reload folder contents in navigation pane #1188
• closes 🐞 Can't create a New File #1146

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

No visual changes should occur due to this PR.

[austincondiff]

@KaiTheRedNinja would your Project Navigator refactor encompass these changes?

[KaiTheRedNinja]

When i was coding it i made sure adding/removing files worked, so yes.

[KaiTheRedNinja]

Since this is already completed by 1243, I'm closing this PR.

[armartinez]

@KaiTheRedNinja I tested you changes and it still doesn't work properly since it keeps the current implementation that relies on the OS filewatcher. Can you maybe confirm @austincondiff ?

[austincondiff]

I will revert to what @KaiTheRedNinja has to say as he is probably a little more familiar than I am. That said, if your changes use a more reliable or performant convention then we should probably at least look into why you are recommending why we use it over what was previously put in place.

[armartinez]

@armartinez Fail enough, let's discuss @KaiTheRedNinja 🙂

[KaiTheRedNinja]

the file watcher is so that changes made within finder (outside of ce) cause updates as well. Is there some issue with that system that i’m not aware of?

Also, are you on the discord?

[armartinez]

@KaiTheRedNinja I am in the discord, we can discuss there, the issue is that it is very slow, at least in my system. I think it should be instant like any other editor.