Conversation
* This will build and push images for linux/amd64 and linux/arm64 to
Docker Hub
* Necessitated by the fact that some of our infra is ARM-based
kilemensi
left a comment
There was a problem hiding this comment.
LGTM!
Last I tried multi-platform build, they were so slow that I just decided to make sure both DEV and PROD use the same architecture (arm64 wherever possible). If things haven't improved, we might have to do the same for ghost (if we haven't).
| uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 |
There was a problem hiding this comment.
Why are we pinning to a specific commit version instead of a specific release e.g.v3 or v3.0.7 if we care about being exact down to a fix?
There was a problem hiding this comment.
I'm following Github's security recommendation for action pinning. I've pinned all actions to their latest release.
I know it's uglier that the usual v6 but the good news is Dependabot understands this format and can still keep our actions updated.
|
@kilemensi Fingers crossed that things have improved in that regard. If not, we can revert this change and only build for |
Context: When trying to deploy the latest changes to prod, I encountered the following error:
It turns out that our host system is actually ARM and therefore we need to build and push the appropriate image for that architecture.