Skip to content

Conversation

@stoopidJSON
Copy link
Member

This will add associations on seeding. Also adds an extra entity on seeding and contact.

Todos

  • Tests

Steps to Test or Reproduce

re-seed the db and see what it looks like after!

This will add an additional entity when seeding, and it will associate
Contacts with Entities at seeding.
resolves #72
@stoopidJSON stoopidJSON requested a review from a team March 28, 2020 20:35
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #78 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   68.24%   68.54%   +0.29%     
==========================================
  Files          12       12              
  Lines         337      337              
==========================================
+ Hits          230      231       +1     
+ Misses        107      106       -1     
Impacted Files Coverage Δ
src/routes/entity.js 43.28% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb3035...7953a6d. Read the comment docs.

Copy link
Member

@joffutt4 joffutt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoopidJSON stoopidJSON merged commit 1cc1669 into master Mar 28, 2020
@stoopidJSON stoopidJSON deleted the revjtanton/issue-72 branch March 28, 2020 20:37
@stoopidJSON stoopidJSON restored the revjtanton/issue-72 branch March 28, 2020 20:37
@stoopidJSON stoopidJSON deleted the revjtanton/issue-72 branch March 28, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants