Updates to Customize Benefit Screen #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Justin-MacIntosh
commented
Nov 20, 2025
Justin-MacIntosh
commented
- feat: Updated Configure Benefit to allow for multiple of the same check to be added.
- feat: Updated Configure Benefit to display the most recent version of each published check.
- chore: Changed benefitResource to block UI interactions while updates are in progress.
…ck to be added. feat: Updated Configure Benefit to display the most recent version of each published check. chore: Changed benefitResource to block UI interactions while updates are in progress.
| checkResultsList.add(result); | ||
| checkResults.put(checkConfig.getCheckId(), Map.of("name", checkConfig.getCheckName(), "result", result)); | ||
|
|
||
| String uniqueCheckKey = checkConfig.getCheckId() + checkNum; |
Collaborator
Author
There was a problem hiding this comment.
This was causing issues when there were multiple checks of the same exact ID.
| newCheck.setOwnerId(userId); | ||
| newCheck.setPublic(true); | ||
| newCheck.setVersion(1); | ||
| newCheck.setVersion(0); |
Collaborator
Author
There was a problem hiding this comment.
The current logic increments the version and then publishes. It's been a bear to get that function just right, so I decided to set the initial version to 0 here so the first published version isn't "2".
| const before = benefit; | ||
|
|
||
| setBenefit({ ...newBenefit }); | ||
| setActionInProgress(true); |
Collaborator
Author
There was a problem hiding this comment.
Updated to be more in line with how we're doing the other API calls. This removes the last of the "Optimistic UI" in the frontend. As snappy as that was I was experiencing some strange behaviors locally that I think had to do with Optimistic API calls. Better to just unify the pattern, especially if it's buggy.
Justin-MacIntosh
force-pushed
the
customize-benefits-update
branch
from
ab2ba84 to
5684067
Compare
Michael-Dratch
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.