Skip to content

Feat/display account in header#336

Merged
joshwanf merged 5 commits intomainfrom
feat/display-account-in-header
Mar 28, 2026
Merged

Feat/display account in header#336
joshwanf merged 5 commits intomainfrom
feat/display-account-in-header

Conversation

@joshwanf
Copy link
Copy Markdown
Collaborator

@joshwanf joshwanf commented Mar 4, 2026

Resolves #316.

  • New <AccountMenu> component that toggles a menu panel
  • Displays the user's email as a clickable element
  • Panel contains the "Logout" button

@joshwanf joshwanf requested a review from prestoncabe as a code owner March 4, 2026 20:47
Copy link
Copy Markdown
Collaborator

@Justin-MacIntosh Justin-MacIntosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the requested change here, I'd like to take a stab at making the email section less bulky. Some emails can get quite long.

This issue may already be defining what you're looking for!!
#326

<Show when={showMenu()}>
<div class="account-menu-panel">
<div class="account-menu-item">
<button type="button" onClick={handleLogout}>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: if you don't click directly on the text "Logout" the functionality doesn't happen, even though you get the hover effect that makes it seem like the button is responding to the mouse.

@joshwanf
Copy link
Copy Markdown
Collaborator Author

joshwanf commented Mar 6, 2026

New changes:

  • Created a new generic component <HamburgerMenu> with a easy-to-use API (hopefully). Resolves Hamburger menu for header #326
  • User email gets wrapped if it is very long
  • Moved "User Guide" link into <Header>'s menu bar

@joshwanf joshwanf added the quick win Great for onboarding, learning how the project works, and building early confidence. label Mar 26, 2026
@joshwanf joshwanf requested a review from earth-walker March 26, 2026 19:05
@joshwanf
Copy link
Copy Markdown
Collaborator Author

joshwanf commented Mar 28, 2026

Bennett comment from Slack:

hey joshwanf this is what I'm seeing in your "Feat/display account in header" branch. is this accurate to what you are working on? generally it seems good, I think using icons (a three-line icon and a X icon) instead of "open" and "close" text would be good. and the close button should be uniform in function/style to the other buttons (using bootstrap I think?). I also wonder if we could grab display name from the google account in addition to email address, would look nicer imo. I can potentially work on this but I probably won't be available until monday to do so. thanks for working on this! (

@joshwanf joshwanf force-pushed the feat/display-account-in-header branch from 1a6fcc3 to c454b3e Compare March 28, 2026 04:21
@joshwanf joshwanf merged commit 730ae24 into main Mar 28, 2026
1 check failed
@joshwanf joshwanf deleted the feat/display-account-in-header branch March 28, 2026 04:23
@earth-walker earth-walker linked an issue Mar 30, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quick win Great for onboarding, learning how the project works, and building early confidence.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hamburger menu for header Display current account on Web App Header

2 participants