Skip to content

Conversation

@ZacharyRSmith
Copy link
Collaborator

Notes

resolves #18

Testing

ran locally, then:

  • logged in as system
  • asserted avatar shows up
  • asserted log out changes ui

@themightychris
Copy link
Member

themightychris commented Sep 3, 2021

@ZacharyRSmith looks great! One small issue with this current implementation is that we're overriding the same html-templates/includes/site.nav-userlinks.tpl that the non-bootstrap4 pages use, so they look funky now because they don't have the right classes for bootstrap3:

Screen Shot 2021-09-03 at 2 10 26 PM

I think we'll need to give the bs4 variant its own path so it can co-exist with the bs3 one for now. So rename site.nav-userlinks.tpl to something like site-bootstrap4.nav-userlinks.tpl and update the {include} that references it in site-bootstrap4.tpl and I think we're good to go!

@github-actions github-actions bot temporarily deployed to pr-22 September 7, 2021 09:49 Destroyed
@ZacharyRSmith
Copy link
Collaborator Author

@themightychris thanks for catching that! I just fixed it, tested locally, then pushed to this PR

@themightychris
Copy link
Member

@ZacharyRSmith looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch login/signup to profile/logout in new header when logged in

3 participants