Offer join form #982 #1034
Offer join form #982 #1034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=========================================
- Coverage 90.92% 90.7% -0.23%
=========================================
Files 114 116 +2
Lines 2701 2755 +54
Branches 31 31
=========================================
+ Hits 2456 2499 +43
- Misses 241 252 +11
Partials 4 4
Continue to review full report at Codecov.
|
OtisRed
force-pushed
the
offer_join_form
branch
from
c26f23f to
abed5df
Compare
juliaanholcer
left a comment
juliaanholcer
left a comment
There was a problem hiding this comment.
Some minor changes in the template are needed to improve the way this form looks.
|
|
||
| export class OfferJoinFormComponent implements OnInit { | ||
| public joinForm: FormGroup = this.fb.group({ | ||
| applicant_email: [''], |
There was a problem hiding this comment.
IMHO camelCase will be better for TypeScript.
| </div> | ||
| <div class="form-group row"> | ||
| <div> | ||
| <button type="submit" class="btn-primary"> |
| </div> | ||
| <div class="form-group row"> | ||
| <div> | ||
| <button type="submit" class="btn-primary"> |
There was a problem hiding this comment.
This form doesn't look good - smth is wrong with grid and RWD doesn't work as well.
| <div class="form-group row"> | ||
| <label class="col-form-label" for="{{ email }}">Email:</label> | ||
| <div class="col-md-5"> | ||
| <input disabled class="form-control" formControlName="applicant_email" id="{{ email }}"/> |
There was a problem hiding this comment.
You use {{ }} to bind to email variable, that is not defined in the component, so as a result, you get empty for attributes in HTML (same problem for all other labels). Define them just using strings, and if you define for attribute in a label don't forget to define id' in input`, so focus can be set after clicking on label.
|
Because of git problems I needed to open this change in another PR. Go to #1066 |
4 participants
This component joins offer and if succesful redirects user to offer details.
There is no new imports I think.
No idea how to test it but that could be taken care of in other PR - I think.