feat: support wildcards and extensions in binary types #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for wildcards in the `binaryMimeTypes` parameter. This allows for more flexibility when defining which responses should be base64-encoded.
forabi
changed the title
Collaborator
|
Nice! I was going to add this this month. Could you add tests for this? |
Contributor
Author
|
@brettstack I added two tests for wildcards and extensions. |
brettstack
approved these changes
Apr 10, 2018
Collaborator
brettstack
left a comment
brettstack
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This was referenced Apr 10, 2018
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
<a name="3.2.0"></a> # [3.2.0](CodeGenieApp/serverless-express@v3.1.3...v3.2.0) (2018-04-10) ### Bug Fixes * **example:** add ca-central-1 to list of regions available ([#133](CodeGenieApp/serverless-express#133)) ([8cfd094](CodeGenieApp/serverless-express@8cfd094)) ### Features * **binary:** allow wildcards and extensions in binary types ([#136](CodeGenieApp/serverless-express#136)) ([8879cf3](CodeGenieApp/serverless-express@8879cf3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for wildcards in the
binaryMimeTypesparameter. This allows for more flexibility when defining which responses should be base64-encoded.