test: fix getSocketPath test for Windows #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettstack
changed the title
brettstack
requested changes
Jul 2, 2018
__tests__/unit.js
Outdated
| test('getSocketPath', () => { | ||
| const socketPath = awsServerlessExpress.getSocketPath('12345abcdef') | ||
| expect(socketPath).toEqual('/tmp/server-12345abcdef.sock') | ||
| var isWin = process.platform === 'win32' |
__tests__/unit.js
Outdated
| expect(socketPath).toEqual('/tmp/server-12345abcdef.sock') | ||
| var isWin = process.platform === 'win32' | ||
| if (isWin) { | ||
| const last = socketPath.split('\\').slice(-1)[0] |
Collaborator
There was a problem hiding this comment.
Better to test the entire socketPath based on process.cwd()
__tests__/unit.js
Outdated
| var isWin = process.platform === 'win32' | ||
| if (isWin) { | ||
| const last = socketPath.split('\\').slice(-1)[0] | ||
| expect(last).toEqual('server-12345abcdef') |
Collaborator
There was a problem hiding this comment.
Instead of if/else, let's do:
const expectedSocketPath = isWin ? .. : ..
expect(socketPath).toBe(expectedSocketPath)
Collaborator
|
Awesome! Thanks for this. I assume this was blocking Windows users from contributing. Travis build is failing due to commit message which I'll change during merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added if statement to see if we're running on Windows. If so, then the socket path will look like this:
\\?\pipe\C:\repo\github\aws-serverless-express\server-12345abcdefrather than:
/tmp/server-12345abcdef.sockso we just evaluate the last segment from the Windows path.