Node.js 6.10 and base64 decode requests fix #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… showcase POST/PUT; move example instructions to example/README.md; update example to Node.js 6.10; added app.local.js to easily run local express
This was referenced May 5, 2017
kahouieong
reviewed
May 8, 2017
Contributor
kahouieong
left a comment
kahouieong
left a comment
There was a problem hiding this comment.
We should consider to bump the version up
| return params.contentTypeHeader ? params.contentTypeHeader.split(';')[0] : '' | ||
| } | ||
|
|
||
| function isContentTypeBinaryMimeType(params) { |
Contributor
There was a problem hiding this comment.
Should we support wildcard here since API Gateway supports that
Collaborator
Author
There was a problem hiding this comment.
Do you mean major version bump? I considered this, but this is a bug fix that we want applied to version 2. However, there is a possibility to break anyone who fixed this on their Express side (e.g. via middleware).
Regardless of which we choose, the version bump will be a separate commit.
Collaborator
Author
There was a problem hiding this comment.
Regarding wildcard support: good point, but let's leave that as a separate issue #70
kahouieong
approved these changes
May 9, 2017
MynockSpit
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: decodes base64 requests (fixes #64); added form to index view to showcase POST/PUT; move example instructions to example/README.md; update example to Node.js 6.10; added app.local.js to easily run local express