Tg 13 kyc vote on playlist #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to vote > views.py > vote_for_track for correct vote functionality but requires testing with multiple users:
# If the upvote already exists, then unset upvote
# If the downvote already exists, then unset downvote
# If upvote already exists and then downvote is clicked, unset upvote and set downvote
# If downvote already exists and then upvote is clicked, unset downvote and set upvote
Update to vote > views.py > vote_for_track for correct vote functionality but requires testing with multiple users:
# If the upvote already exists, then unset upvote
# If the downvote already exists, then unset downvote
# If upvote already exists and then downvote is clicked, unset upvote and set downvote
# If downvote already exists and then upvote is clicked, unset downvote and set upvote
Vote view re-factoring (work in progress) with aim of vote model unit testing
…eHubOrg/TeamGroove into TG-13--KYC--vote_on_playlist
finish moving the vote calculation to `models.py`.
Moved logic to `models.py`. Added a `utils.py` with vote logic. Renamed voting methods from `spotify_up_vote`/`spotify_down_vote` to just `up_vote`/`down_vote`
Working on getting the view tests to work with login.
pylance from reformatting .env files.
an unexpected 404 error.
including testing two users voting.
variables rather than class variables.
sfkleach
reviewed
Jun 1, 2022
| build-backend = "poetry.core.masonry.api" | ||
|
|
||
| [tool.pyright] | ||
| exclude = [".env", "env.example"] |
Contributor
Author
There was a problem hiding this comment.
Pyright is apparently used by VS Code. However, the problem with the .env file doesn't appear to be related to pyright misbehaving so this change doesn't seem to help.
sfkleach
approved these changes
Jun 1, 2022
Comment on lines
+25
to
+56
| # Voting the same way twice resets the vote | ||
| # If the user has already voted up... | ||
| if self.track_vote > 0: | ||
| # And the user votes up... | ||
| if vote_type == 1: | ||
| # Then reset the vote | ||
| self.track_vote = 0 | ||
| # Otherwise if the user votes down... | ||
| else: | ||
| # Then record a down vote | ||
| self.track_vote = -1 | ||
| # If the user has already voted down... | ||
| elif self.track_vote < 0: | ||
| # And the user votes up... | ||
| if vote_type == 1: | ||
| # Then record an up vote | ||
| self.track_vote = 1 | ||
| # Otherwise if the user votes down... | ||
| else: | ||
| # Then reset the vote | ||
| self.track_vote = 0 | ||
| # Otherwise the user has not voted yet | ||
| else: | ||
| # So if the user votes up... | ||
| if vote_type == 1: | ||
| # Record an up vote | ||
| self.track_vote = 1 | ||
| # So if the user votes down... | ||
| else: | ||
| # Record a down vote | ||
| self.track_vote = -1 | ||
| self.save() |
Contributor
There was a problem hiding this comment.
Consider:
def update_vote(self, vote_type):
vote_upwards = 1 if vote_type > 0 else -1
same_direction = -1 if vote_upwards == self.track_vote else 1
self.track_vote += vote_upwards * same_direction
assert -1 <= self.track_vote <= 1
self.save()
Comment on lines
150
to
151
| else: | ||
| pass |
Contributor
There was a problem hiding this comment.
Consider removing else: pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single user vote function, now with unit and view tests.