`jenkins` ruleset doesn't work when using Java 21

[nre-ableton]

When I try using the new jenkins ruleset introduced in CodeNarc 3.5.0 with Java 21, I get an error:

ERROR: org.codenarc.analyzer.AnalyzerException: Error analyzing source file: Jenkinsfile; BUG! exception in phase 'semantic analysis' in source unit 'None' Unsupported class file major version 65
org.codenarc.analyzer.AnalyzerException: Error analyzing source file: Jenkinsfile; BUG! exception in phase 'semantic analysis' in source unit 'None' Unsupported class file major version 65

The ruleset works fine when using Java 17.

[lslonina]

Faced same issue, it can be due to groovy and java 21 version support.
As checked Java 21 constant was added in version 4.0.11: https://issues.apache.org/jira/browse/GROOVY-10986

Codenarc has groovy 4.0.7. So small upgrade is required (here or in your build script).

Probably same applies for groovy 3 based codenarc.

[chrismair]

Codenarc has groovy 4.0.7. So small upgrade is required (here or in your build script).

Thanks for that info. Have either of you tried explicitly specifying the later Groovy version in your build/classpath to override the default 4.0.7? Does that fix it?

[lslonina]

Yes, I have used newest available groovy 4 dependency. All works fine. I'm on gradle and upgraded as specified in: CodeNarc Gradle

[chrismair]

Excellent. I'm glad there is a simple workaround. I'll plan to update the formal dependency in CodeNarc for the next release.

[nre-ableton]

@chrismair sounds good. Should I close this issue as "wontfix" or let you close it with a corresponding documentation "fix"?

[nre-ableton]

Hmm, actually, now that I think about it, I'm not sure that this is a great solution for this problem. While this workaround is great for developers, it won't work well on Jenkins itself, where the Groovy version is (sadly) stuck at 2.4.21.

Is there any way that we can avoid the JDK21 constant in the jenkins ruleset itself?

[chrismair]

While this workaround is great for developers, it won't work well on Jenkins itself, where the Groovy version is (sadly) stuck at 2.4.21.

But CodeNarc is not running "within" Jenkins. It is running as part of a user/developer build (perhaps kicked off by Jenkins, but not necessarily) that is analyzing Jenkins Groovy files. The user still gets to configure how CodeNarc runs and its classpath.

[nre-ableton]

While this workaround is great for developers, it won't work well on Jenkins itself, where the Groovy version is (sadly) stuck at 2.4.21.

But CodeNarc is not running "within" Jenkins. It is running as part of a user/developer build (perhaps kicked off by Jenkins, but not necessarily) that is analyzing Jenkins Groovy files. The user still gets to configure how CodeNarc runs and its classpath.

Yes, this is true. I guess that historically our wrapper has attempted to use the same version of Groovy that Jenkins runs, just for the sake of symmetry.

[chrismair]

I'll leave this open as documentation until the next release, and will upgrade the Groovy version then.

[nvuillam]

@chrismair what are the recommended versions of java & groovy to run CodeNarc ?
We have a similar issue with npm-groovy-lint :)
cc @stevenh

[nre-ableton]

@chrismair what are the recommended versions of java & groovy to run CodeNarc ? We have a similar issue with npm-groovy-lint :) cc @stevenh

Theoretically, anything >=4.0.11 should work fine.

[nvuillam]

@chrismair what are the recommended versions of java & groovy to run CodeNarc ? We have a similar issue with npm-groovy-lint :) cc @stevenh

Theoretically, anything >=4.0.11 should work fine.

We ship with groovy 3.x ... thanks for the info :)

[chrismair]

I have reproduced the problem and confirmed that it appears to be fixed when using Groovy 4.0.15 and Groovy 3.0.22.

[chrismair]

Will be available in CodeNarc 3.6.0