Additional PropertiesFileRuleSetConfigurer.configure(..) log aiding debugging.#797
Merged
chrismair merged 2 commits intoCodeNarc:masterfrom Jul 20, 2025
dlehammer:propertiesFilename_debug-log
Merged
Additional PropertiesFileRuleSetConfigurer.configure(..) log aiding debugging.#797chrismair merged 2 commits intoCodeNarc:masterfrom dlehammer:propertiesFilename_debug-log
PropertiesFileRuleSetConfigurer.configure(..) log aiding debugging.#797chrismair merged 2 commits intoCodeNarc:masterfrom
dlehammer:propertiesFilename_debug-log
Conversation
chrismair
reviewed
Jul 19, 2025
src/main/groovy/org/codenarc/ruleset/PropertiesFileRuleSetConfigurer.groovy
Show resolved
Hide resolved
… in-order to eliminate ambiguity. @see #797 (comment)
chrismair
approved these changes
Jul 20, 2025
Contributor
|
Thank you for that contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (or similar) debug logging would've been very helpful in teasing out the root cause of gradle/gradle#34239 , when attempting to reason about state versus output for the
getActualPropertiesFile(..)branches 🤓