mongo doesn't like dotted keys

[tjmehta]

No description provided.

[podviaznikov]

how did you find that there is a problem with the dotted keys?

[bkendall]

are you sure it was the dots? I thought it might have been the forward slashes...

[tjmehta]

exception: The dotted field '/etc/nginx/conf.d' in 'container.inspect.Config.Volumes./etc/nginx/conf.d' is not valid for storage.

[tjmehta]

"dotted-field"

[tjmehta]

We're getting 1 test failure currently on master - which is the one you see. it passes locally was going to debug it in the morning.

[tjmehta]

btw i did a unit test on the dotted key removal here are the results
BEFORE

{
  foo: {
    bar: {
      baz: {
        "wut.hey": 10,
        "w.hey": 10,
        yolo: 10
      }
    }
  },
  baz: {
    "wut.hey": 10,
    "w.hey": 10,
    yolo: 10
  },
  "wut.hey": 10,
  yolo: 10,
  "but.hey": 10
}

UNIT

function removeDottedKeys (obj) {
    if (typeof obj === 'object') {
        Object.keys(obj).forEach(function (key) {
            if (~key.indexOf('.')) {
                delete obj[key];
            }
            removeDottedKeys(obj[key]);
        });
    }
}

var x = {
  foo: {
    bar: {
      baz: {
        "wut.hey": 10,
        "w.hey": 10,
        yolo: 10
      }
    }
  },
  baz: {
    "wut.hey": 10,
    "w.hey": 10,
    yolo: 10
  },
  "wut.hey": 10,
  yolo: 10,
  "but.hey": 10
};
removeDottedKeys(x);
console.log(JSON.stringify(x, null, '\t'));

AFTER

{
    "foo": {
        "bar": {
            "baz": {
                "yolo": 10
            }
        }
    },
    "baz": {
        "yolo": 10
    },
    "yolo": 10
}

[bkendall]

❤️ for tests

[tjmehta]

Verified on staging - issue repros when using a Volume with a "." in the path - I have fix on staging and problem does not repro anymore

[tjmehta]

so the problem is resolved.

[tjmehta]

thanks for the review!