add image ignore #427
Merged
add image ignore #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configs/.env
Outdated
Contributor
There was a problem hiding this comment.
why not DOCKER_IMAGE_BUILDER_NAME and put it with the other two that share that prefix?
Contributor
Author
There was a problem hiding this comment.
because I like to be different ;), fix'd
Contributor
There was a problem hiding this comment.
does it need it need to return this object?
Contributor
Author
There was a problem hiding this comment.
I just needed a way to test this, there is no harm in returning here.
Contributor
|
tests are failing, otherwise looks fine to me |
Contributor
|
fix the tests, pretty please! 🍰 |
Contributor
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.