Redis locks ttl

[podviaznikov]

Add expires time to the redis mutex. By default after 10 mins all locks would be gone.

[anandkumarpatel]

this one LGTM, but have you tested this yet?

[podviaznikov]

@anandkumarpatel what do you mean by "tested"? Some specific behavior or if locks will be removed after expiration period?

[anandkumarpatel]

as in, do you have a branch of API server running this right now on IO so we can test it before we put it on staging

[tjmehta]

use eson to translate readable value to ms

[tjmehta]

👍

[tjmehta]

@anandkumarpatel he has a unit test. will not be able to test in reality since all locks currently unlock themselves.

[anandkumarpatel]

No I mean like test on io just to ensure all functions work.
On Dec 15, 2014 7:42 PM, "Tejesh Mehta" notifications@github.com wrote:

@anandkumarpatel https://github.com/anandkumarpatel he has a unit test.
will not be able to test in reality since all locks currently unlock
themselves.

—
Reply to this email directly or view it on GitHub
#434 (comment).

[tjmehta]

can you just set this value in .env.test

[tjmehta]

verified on tj-stage and anton-stage