Skip to content

Deployments api #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Mar 6, 2015
Merged

Deployments api #569

merged 64 commits into from
Mar 6, 2015

Conversation

@podviaznikov
Copy link
Member

@podviaznikov podviaznikov commented Feb 26, 2015

  • update node-github lib to have deployments api.
  • create GitHub Status when build was started/fininished/errored
  • create GitHub Deployment Status when instance was deployed/errored for the new build
  • remove old code: runnabot, public notifications

If there is not servers linked to the PR/branch than we are sending special status:
server selection with yellow icon.

UI preview: https://github.com/podviaznikov/hellonode/pull/59. Scroll to the bottom.

How to test:

  • deploy this branch on your api server.
  • open your own web pointed to the api server.
  • create box with any github repo
  • create new branch and PR in the repo
  • push new commit to the branch

podviaznikov and others added 29 commits February 26, 2015 14:13
@podviaznikov
deployments api. start
b3f01c9 
* update node-github lib to have deployments api.
* add call for createDeployment when push for configured repo received.
@podviaznikov
use user accessToken
931ce38 
Don’t use Runnabot access token
@podviaznikov
start handling deployment event
548161f 
* update node-github
* pass payload to the new deployment
@podviaznikov
changing deployment status
0600efc
@podviaznikov
get rid of github-notifications
7e6f02c
@podviaznikov
remove PR bot code
288f426
@podviaznikov
remove old code
d1509ec
@podviaznikov
passing target url for the deployment status
a4c1f65
@podviaznikov
trigger deployment for each box
fd5c6e7 
Start work for triggering github deployment for each server.
@podviaznikov
fix syntax error
e852769
@podviaznikov
reorganize code. minors
efcb921
@podviaznikov
creating build statuses
64da9a6
@podviaznikov
fix typos
f6f0f27
@podviaznikov
better testing for the statuses
cf05335
@prafulrana
playing with text
01f7bf5
@podviaznikov
remove old code
10e2656 
jshint cleanups
@podviaznikov
better messaging
2ac8f3a
@podviaznikov
refactor redeploy code
4a1dadc
@podviaznikov
pull statuses code into separate file
a6b0a2a 
models/api/pull-request has code:
1. for statues api
1. for deployments api
@podviaznikov
progress with refactoring
aa51a33 
move all deployment api calls to the models/api/pull-request
@podviaznikov
add debug logs
c69b0a9
@podviaznikov
remove global try/catch
1a8d793
@podviaznikov
use commit instead of branch
29d30f1
@podviaznikov
disable statuses by default
e736c84
@podviaznikov
code cleanups
a1bd492
@podviaznikov
fix mw result call
e21336a
@podviaznikov
trigger deploy
81c6e15
@podviaznikov
handle error cases
1d41c57 
handle case when build or deployment failed. update tests
@podviaznikov
remove old hooks handling
1e51bd7 
1. remove old code for handling each commit building.
2.  remove old tests.
3. add new test for handling failed deployment
@podviaznikov podviaznikov changed the title [WIP] Deployments api. start [WIP] Deployments api Mar 2, 2015
@podviaznikov
merge & updates
6708b70 
1. merge master
2. removed code implemented in master
3. fetch instance creator for each instance instead of using first one
@podviaznikov
fixes and cleanups
0bde653
@podviaznikov
implement serverSelection status
9fceb47
@podviaznikov
improvements
e7b9056 
1. method renamings
2. fetch commit message
3. pass correct box owner name
@podviaznikov
fix lint erros & missing require
fbff7db
@podviaznikov
Copy link
Member Author

podviaznikov commented Mar 5, 2015

@prafulrana can you review text for build and deployments statuses?
Just check description fields in each method here: https://github.com/CodeNow/api/blob/integrate-github-deployments-api/lib/models/apis/pullrequest.js

@tjmehta tjmehta changed the title Deployments api [wip] Deployments api Mar 5, 2015
@podviaznikov podviaznikov changed the title [wip] Deployments api Deployments api Mar 5, 2015
@podviaznikov
Copy link
Member Author

podviaznikov commented Mar 5, 2015

@anandkumarpatel, @bkendall can you review this one more time. I added few tests, applied your feedback and added small pice of additional functionality: set special server selection status when there is no server linked to the PR/branch.

@podviaznikov
Copy link
Member Author

podviaznikov commented Mar 5, 2015

@tjmehta feel free to do code review too. Would like to deploy it tomorrow. Feel pretty comfortable about this PR.

bkendall
bkendall reviewed Mar 5, 2015
View reviewed changes
lib/routes/actions/github.js
Copy link
Contributor

@bkendall bkendall Mar 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@podviaznikov
Copy link
Member Author

podviaznikov commented Mar 5, 2015

@anandkumarpatel I addressed most of your comments. But few more things were changed since last review. Please do quick review and let me know if you ok with this PR

@bkendall
Copy link
Contributor

bkendall commented Mar 5, 2015

alright - pending your tests passing, I think I'm good to go on these (stupid tests... come on tests)

LGTM 👍

@podviaznikov
Copy link
Member Author

podviaznikov commented Mar 5, 2015

thanks @bkendall. Created task for that - https://runnable.atlassian.net/browse/SAN-1058.
Yeah, I'm retrying tests periodically.

anandkumarpatel pushed a commit that referenced this pull request Mar 6, 2015
Merge pull request #569 from CodeNow/integrate-github-deployments-api
e7d079d 
Deployments api
@anandkumarpatel anandkumarpatel merged commit e7d079d into master Mar 6, 2015
@anandkumarpatel anandkumarpatel deleted the integrate-github-deployments-api branch March 6, 2015 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@podviaznikov @bkendall @cflynn07 @tjmehta @prafulrana @anandkumarpatel