adding rabbit related things for khronos#164
Merged
anandkumarpatel merged 6 commits intomasterfrom Oct 14, 2015
Merged
Conversation
Contributor
Author
|
wait on this khronos pr, but this will be needed then! |
|
|
code looks good, deploy to beta before merging |
Contributor
Author
|
ohhh yeah. that worked like a charm. I'm so happy :) |
Contributor
|
lgtm. Good that we have default command set to json-filtered output |
|
for the cron since we are not doing it inside khronos itself, you will need to also create some type of monitoring mechanism (maybe datadog if event was not seen after x time) |
anandkumarpatel
pushed a commit
that referenced
this pull request
Oct 14, 2015
adding rabbit related things for khronos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can add cron to this PR if you would like, but I want to verify that it works fine before I start regularly hammering it.