fix consul and vault images and commands#209
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
these are values that were defined in the previous image that I had to add manually
Contributor
|
I assume the additions are to fit our particular image of consul? Other than a few questions, looks fine to me. I assume you tested this on beta? |
Contributor
|
Super 💯 👍 🐲 |
rsandor
added a commit
that referenced
this pull request
Nov 20, 2015
fix consul and vault images and commands
Contributor
Author
yes
gamma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both are now runnable controlled images and should work a little better, imo