Skip to content

Add ec2 inventory#225

Merged
bkendall merged 21 commits intomasterfrom
add-ec2-inventory
Dec 14, 2015
Merged

Add ec2 inventory#225
bkendall merged 21 commits intomasterfrom
add-ec2-inventory

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Dec 6, 2015

Delta hosts (ssh/config),
Delta variables (first pass - ansible/delta-hosts/...),
EC2 Security Groups Automation (ansible/roles/ec2/...).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this role would probably be better if the ips came from the variables defined in all.yml.

it would be even better if we could somehow get each dictionary inside of each service and then all we would have to do is require that at the top of the file and this would pick it up

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a slightly bigger refactor than maybe I had in mind in the scope of this initial commit, but we can slack about what you meant – I'd need a reference example (and I'm sure there plenty in this repo).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that these should probably come from all.yml (the ports, mostly). when we get the stuff from the security folks going "you need to close these ports", we can come back to this

@bkendall
Copy link
Copy Markdown
Contributor

bkendall commented Dec 7, 2015

so, I'd think a goal in this would be to not have any of the sg-xxxxxxx things listed out anywhere, is that anywhere close to reasonable? with them hard-coded like that, we can't just do a lookup and go. or, is that csv file that's checked in generated by ansible somehow? I figure we can probably do something similar to what we do for the hosts to get the inventory of security groups, though I'm not sure off the top of my head if that's reasonable to go for. Let me know your thoughts

@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Dec 7, 2015

Well, we would have to at least have the SG's listed in inventory (detla-hosts/variables), the csv and template can be removed so I will whack those before doing a final commit. As I mentioned to @anandkumarpatel I will be making a few final commits before this is really ready to merge, so let's circle back EOB and maybe merge this a mañana?

¡Se gusta!

@und1sk0 und1sk0 assigned bkendall and anandkumarpatel and unassigned bkendall Dec 9, 2015
@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Dec 9, 2015

Rebased master on this branch.

Please merge me!

Comment thread ansible/delta-hosts/variables Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user_content_domain=runnableapp.com (prod)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commiting

Comment thread ansible/delta-hosts/hosts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong domain

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vpc_id is also a duplicate

Comment thread ansible/sg_configure.yml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'v never seen a role with a / but if it works it works :)

@bkendall
Copy link
Copy Markdown
Contributor

best of luck.

bkendall added a commit that referenced this pull request Dec 14, 2015
@bkendall bkendall merged commit dc76c6d into master Dec 14, 2015
@bkendall bkendall deleted the add-ec2-inventory branch December 14, 2015 23:43
@und1sk0 und1sk0 restored the add-ec2-inventory branch December 16, 2015 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants