Conversation
There was a problem hiding this comment.
this role would probably be better if the ips came from the variables defined in all.yml.
it would be even better if we could somehow get each dictionary inside of each service and then all we would have to do is require that at the top of the file and this would pick it up
There was a problem hiding this comment.
sounds like a slightly bigger refactor than maybe I had in mind in the scope of this initial commit, but we can slack about what you meant – I'd need a reference example (and I'm sure there plenty in this repo).
There was a problem hiding this comment.
agree that these should probably come from all.yml (the ports, mostly). when we get the stuff from the security folks going "you need to close these ports", we can come back to this
|
so, I'd think a goal in this would be to not have any of the |
|
Well, we would have to at least have the SG's listed in inventory (detla-hosts/variables), the csv and template can be removed so I will whack those before doing a final commit. As I mentioned to @anandkumarpatel I will be making a few final commits before this is really ready to merge, so let's circle back EOB and maybe merge this a mañana? ¡Se gusta! |
… S3 buckets for Delta.
|
Rebased master on this branch. Please merge me! |
There was a problem hiding this comment.
user_content_domain=runnableapp.com (prod)
There was a problem hiding this comment.
vpc_id is also a duplicate
There was a problem hiding this comment.
i'v never seen a role with a / but if it works it works :)
|
best of luck. |
Delta hosts (ssh/config),
Delta variables (first pass - ansible/delta-hosts/...),
EC2 Security Groups Automation (ansible/roles/ec2/...).