Skip to content

Add ec2 inventory#242

Merged
anandkumarpatel merged 7 commits intomasterfrom
add-ec2-inventory
Dec 17, 2015
Merged

Add ec2 inventory#242
anandkumarpatel merged 7 commits intomasterfrom
add-ec2-inventory

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Dec 17, 2015

Had to fix some hosts and group-vars.

@und1sk0 You have to put a space between your brackets to make them appear as checkboxes - Casey

@cflynn07
Copy link
Copy Markdown
Contributor

lgtm, get a 2nd reviewer

@anandkumarpatel
Copy link
Copy Markdown

Is access key only for that role? Should it be global

@anandkumarpatel
Copy link
Copy Markdown

Actually move the key into all.yml so we don't have to dig around multi files when we want to remove keys

Comment thread ansible/sg_configure.yml Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for these, all always gets invoked

Comment thread ansible/group_vars/ec2_sg.yml Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove me

anandkumarpatel pushed a commit that referenced this pull request Dec 17, 2015
@anandkumarpatel anandkumarpatel merged commit 02f5212 into master Dec 17, 2015
@anandkumarpatel anandkumarpatel deleted the add-ec2-inventory branch December 17, 2015 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants