Skip to content

Remove CLUSTER_WORKERS env, add ENABLE_CLUSTERING#261

Merged
cflynn07 merged 2 commits intomasterfrom
SAN-3043-cache
Jan 12, 2016
Merged

Remove CLUSTER_WORKERS env, add ENABLE_CLUSTERING#261
cflynn07 merged 2 commits intomasterfrom
SAN-3043-cache

Conversation

@cflynn07
Copy link
Copy Markdown
Contributor

@cflynn07 cflynn07 commented Jan 9, 2016

No description provided.

@anandkumarpatel
Copy link
Copy Markdown

+1, merge once other PR's are merged

@cflynn07 cflynn07 mentioned this pull request Jan 11, 2016
5 tasks
@bkendall
Copy link
Copy Markdown
Contributor

  1. this MUST be merged in paralle with SAN 3043 cache navi#97.
  2. can we add NUM_CLUSTER_WORKERS=20? I remember testing what that number should be and that seemed to give us the best performance (because node v0.10's clustering sucks)

@cflynn07
Copy link
Copy Markdown
Contributor Author

@bkendall Last week, we tested it again. Performance was dramatically boosted by running clustering to match the number of CPUs on the server.
https://docs.google.com/spreadsheets/d/1GoesHGn92k3TfltMB64sUHJ_rm6kG6lVAxnjFOUSjmg/edit
See row 40 vs row 38

Clustering to match the number of cores on a server is the recommended approach in Node.js's documentation

Navi now runs on node v4.2.*

@bkendall
Copy link
Copy Markdown
Contributor

👍 good to know!

* origin/master: (29 commits)
  Added link to list
  Added detention to list
  that's the ticket!
  (oops)
  Delta.
  wrong IP for gamma-api-worker
  move repo to repo folder so we do not conflit when adding dockerfile
  remove depth
  Revert "Revert "modify building for faster deploys""
  change to fix deploy workers
  changed worker in gamma-hosts/hosts from gamma-worker to gamma-api-worker
  updated config file update ec2 instance and update gamma host with different worker
  change comment
  dummy dumb dumb
  last minute fixes
  missing ""
  Wiping the Redis check, as it does not work.
  tag entire role
  add metis to gamma
  update weave
  ...
cflynn07 added a commit that referenced this pull request Jan 12, 2016
Remove CLUSTER_WORKERS env, add ENABLE_CLUSTERING
@cflynn07 cflynn07 merged commit 296eb21 into master Jan 12, 2016
@bkendall bkendall deleted the SAN-3043-cache branch March 3, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants