Conversation
This was referenced Jan 11, 2016
added 2 commits
January 11, 2016 10:36
This was referenced Jan 11, 2016
added 2 commits
January 11, 2016 10:41
3 tasks
Contributor
|
I checked all the cross references to other repos and this all seems pretty straight forward. Let's push all of these out to gamma this afternoon and merge it if nothing goes pear shaped. |
Member
|
Does this need to change, too? https://github.com/CodeNow/devops-scripts/blob/master/ansible/group_vars/all.yml#L37-37 |
Author
@Nathan219 nope. That's the var that we use to generate the API url's in all those spots where I'm appending |
Contributor
|
Instead of prepending |
Author
@cflynn07 Done. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API_HOST -> API_URL
This has been plaguing us long enough. It's time we close all these out:
Subsequent changes needed in the projects:
Link — CodeNow/link#10
Charon — CodeNow/charon#38
Detention — CodeNow/detention#13
Eru — CodeNow/eru#2
Runnable-angular —CodeNow/runnable-angular#1431