Skip to content

SAN-3314 Use API_URL#263

Merged
Myztiq merged 6 commits intomasterfrom
SAN-3314-use-api-url
Jan 14, 2016
Merged

SAN-3314 Use API_URL#263
Myztiq merged 6 commits intomasterfrom
SAN-3314-use-api-url

Conversation

@Myztiq
Copy link
Copy Markdown

@Myztiq Myztiq commented Jan 11, 2016

API_HOST -> API_URL

This has been plaguing us long enough. It's time we close all these out:

Subsequent changes needed in the projects:
Link — CodeNow/link#10
Charon — CodeNow/charon#38
Detention — CodeNow/detention#13
Eru — CodeNow/eru#2
Runnable-angular —CodeNow/runnable-angular#1431

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Jan 11, 2016

I checked all the cross references to other repos and this all seems pretty straight forward. Let's push all of these out to gamma this afternoon and merge it if nothing goes pear shaped.

@Nathan219
Copy link
Copy Markdown
Member

@Myztiq
Copy link
Copy Markdown
Author

Myztiq commented Jan 11, 2016

Does this need to change, too? https://github.com/CodeNow/devops-scripts/blob/master/ansible/group_vars/all.yml#L37-37

@Nathan219 nope. That's the var that we use to generate the API url's in all those spots where I'm appending https://

@cflynn07
Copy link
Copy Markdown
Contributor

Instead of prepending https:// could we make that configurable / an ENV var?

@Myztiq
Copy link
Copy Markdown
Author

Myztiq commented Jan 14, 2016

Instead of prepending https:// could we make that configurable / an ENV var?

@cflynn07 Done.

@bkendall
Copy link
Copy Markdown
Contributor

LGTM

Myztiq added a commit that referenced this pull request Jan 14, 2016
@Myztiq Myztiq merged commit 58a64ce into master Jan 14, 2016
@Myztiq Myztiq deleted the SAN-3314-use-api-url branch January 14, 2016 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants