Skip to content

grep -rl 'sudo:' | xargs ...#402

Merged
bkendall merged 2 commits intomasterfrom
SAN-3312-the-becomining
Apr 5, 2016
Merged

grep -rl 'sudo:' | xargs ...#402
bkendall merged 2 commits intomasterfrom
SAN-3312-the-becomining

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Mar 29, 2016

  • literally replaced all sudo: yes with become: true

Dependencies

  • N/A

Reviewers

Tests

  • Just for kicks we can run a deploy that requires elevated privileges but we've been using "become: true" in all new playlists for a while.

Integration Test

Please follow the guidelines presented in the How to Test an API PR
article when setting-up and performing tests.

  • Integration Tested @ commitsh by @und1sk0 on (epsilon)

Comment thread ansible/ansible.cfg Outdated
@@ -1,3 +1,3 @@
[defaults]
# Required so `sudo: yes` does not lose the environment variables, which hold the ssh-agent socket
# Required so `become: true` does not lose the environment variables, which hold the ssh-agent socket
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment still accurate?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case someone uses sudo instead of become let's keep.

@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Apr 4, 2016

Please review and merge, thanks.

@bkendall bkendall merged commit 830c660 into master Apr 5, 2016
@bkendall bkendall deleted the SAN-3312-the-becomining branch April 5, 2016 16:35
@bkendall bkendall removed their assignment Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants