Conversation
| ansible_ssh_private_key_file=~/.ssh/delta.pem | ||
| api_hello_runnable_github_token=88ddc423c2312d02a8bbcaad76dd4c374a30e4af | ||
| bastion_sshd_port=60506 | ||
| core_file_dir=/var/log |
There was a problem hiding this comment.
is there a reason this will be different in different env's. if not, then put in all.yml
Contributor
Author
|
Please take a look. |
| [epsilon:vars] | ||
| ansible_ssh_private_key_file=~/.ssh/epsilon.pem | ||
| bastion_sshd_port=60519 | ||
| core_file_dir=/docker/app_cores |
Contributor
There was a problem hiding this comment.
why are you putting this in /docker in epsilon, specifically?
added 2 commits
April 5, 2016 10:57
| ## | ||
| ## cores and logs | ||
| ## | ||
|
|
Contributor
There was a problem hiding this comment.
can we set a more sane default like /var/log/core?
Contributor
Author
There was a problem hiding this comment.
Sure... but we will need to make sure the directory exists..
Contributor
|
barring the actual path, this looks fine |
|
+1 for change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core_file_dirinstead of/var/logDependencies
Reviewers
Tests
Deployment (post-merge)