Skip to content

All about that base, bout that base.#411

Merged
und1sk0 merged 2 commits intomasterfrom
SAN-3714-base-playbook
Apr 5, 2016
Merged

All about that base, bout that base.#411
und1sk0 merged 2 commits intomasterfrom
SAN-3714-base-playbook

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Apr 4, 2016

  • The big change here is that the node role now installs the latest npm. We don't run this very often - almost never. And now there's a base.yml which cooks a base image.

Dependencies

  • an ubuntu system on AWS.

Reviewers

Tests

Test any modifications on one of our environments.

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to epsilon
  • deployed to gamma
  • deployed to delta

Comment thread ansible/roles/node/tasks/main.yml Outdated
become: true
npm:
name=npm
state=latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want latests (which should be >= 3). What we really need is the latest node 2.

@und1sk0 und1sk0 added the review label Apr 4, 2016
@und1sk0 und1sk0 assigned und1sk0 and rsandor and unassigned und1sk0 Apr 4, 2016
@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Apr 4, 2016

Please reveiw.

@anandkumarpatel
Copy link
Copy Markdown

+1

@und1sk0 und1sk0 merged commit ba287e8 into master Apr 5, 2016
@und1sk0 und1sk0 deleted the SAN-3714-base-playbook branch April 5, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants