Skip to content

San 3496 json logs#432

Merged
und1sk0 merged 16 commits intomasterfrom
SAN-3496-json-logs
Apr 25, 2016
Merged

San 3496 json logs#432
und1sk0 merged 16 commits intomasterfrom
SAN-3496-json-logs

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Apr 21, 2016

  • Logs now rotate per hour
  • Logs now output as JSON formatted logs

Dependencies

  • bunyan, lq

Reviewers

Tests

Test any modifications on one of our environments.

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to epsilon
  • deployed to gamma
  • deployed to delta
  • Update log locations in wiki, tell folks in #general (make sticky?)

@und1sk0 und1sk0 added the review label Apr 21, 2016
owner=syslog
group=syslog

- name: create runnable bin directory
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we no longer need the rotate script at all? Is this somehow handled by rsyslog itself?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Syslog will simply open a new log file every hour.

Actually, let me add one more thing...

@und1sk0 und1sk0 assigned rsandor and und1sk0 and unassigned rsandor Apr 21, 2016
$ActionFileDefaultTemplate RSYSLOG_TraditionalFileFormat

# Runnable JSON logging format
$template RunnableJSON,"%msg:2:$:jsonr%\n"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead an add a comment that explains this line.

@@ -0,0 +1,17 @@
# not really an alias
function logtail() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's comment these functions similar to the way we comment them in dock-init, please and ty 👯

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the methods look like they do in dock-init:
https://github.com/CodeNow/dock-init/blob/master/lib/consul.sh#L28

@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Apr 22, 2016

@@ -0,0 +1,19 @@
---
- name: copy bash aliases to ubuntu
tags: [ loggly, deploy ]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, do not want to do this every deploy

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the only way I could get it to work. Suggest alternate tag? bash_aliases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants