Swarm CloudWatch#447
Conversation
| state: directory | ||
| owner: ubuntu | ||
| group: ubuntu | ||
| mode: 0775 |
There was a problem hiding this comment.
want to be able to write to it and get into the folder? and doesn't need to be as root? do you have a suggestion for something different?
There was a problem hiding this comment.
Of the four octets, the trailing three are, in order, user, group and other. If you are only concerned about user ubuntu being able to read the directory, literally setting the octet to "5" is sufficient (read=true, execute=true), or mode 0500. I am not aware of Runnable running anything set-groupId, so the group octet (00X0) is irrelevant, but to be safe mode 0755 (user read, write, execute; group read and execute; other read and execute).
|
Adding my check... I get the general gist of the Javascript even if I am not there yet in terms of it totally making sense to me, everything looks copacetic. ETA - make /opt/runnable mode 0700 or 0755 |
done |
| @@ -0,0 +1,181 @@ | |||
| var AWS_ACCESS_KEY = process.env.AWS_ACCESS_KEY | |||
There was a problem hiding this comment.
surprised this file is not in a seperate repo somewhere ... as it get more advance/critical lets make sure to break it out
There was a problem hiding this comment.
I don't know where to put it...
| -v /opt/ssl/docker/swarm-manager:/opt/ssl/docker/swarm-manager:ro | ||
| -v /var/log:/var/log | ||
|
|
||
| container_run_args: npm start >> /var/log/{{ name }}.log 2>&1 |
There was a problem hiding this comment.
see other comment about logging...
|
LGTM |
3 participants
Reviewers
Tests
Deployment (post-merge)