add https to navi, remove userland hipache#472
Merged
anandkumarpatel merged 4 commits intomasterfrom May 16, 2016
Merged
Conversation
added 2 commits
May 13, 2016 16:28
13 tasks
| npm_version: "2.8.3" | ||
|
|
||
| redis_ca_cert_path: /opt/ssl/{{ name }}/redis/ca.pem | ||
| content_domain_certs: /opt/ssl/{{ user_content_domain }} |
Contributor
There was a problem hiding this comment.
how are you getting these certificates to this spot?
Author
There was a problem hiding this comment.
problem? should I make this global? was following redis pattern above
Contributor
There was a problem hiding this comment.
that should be fine, I suppose
Author
There was a problem hiding this comment.
so I will just leave it like this ...
anandkumarpatel
changed the title
| navi_host_address: "{{ hostvars[groups['navi'][0]]['ansible_default_ipv4']['address'] }}" | ||
| navi_port: 3567 | ||
| navi_http_port: 3567 | ||
| navi_https_port: 443 |
Contributor
There was a problem hiding this comment.
don't think you were serving https on this port
Author
There was a problem hiding this comment.
navi listens to 2 ports.
| to_port: "{{ navi_port }}" | ||
| from_port: "{{ navi_http_port }}" | ||
| to_port: "{{ navi_http_port }}" | ||
| group_id: "{{ sg_hipache }}" |
Author
There was a problem hiding this comment.
yep, will still have that box. IP table rules from sg_hipache to navi box for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers
Tests
Deployment (post-merge)