Conversation
|
The latest push to PR-18 is running on SAN-4053-user-tracking-link |
4 tasks
Contributor
|
I see no functional testing to ensure the new field is actually being put into to the database. |
Contributor
Author
|
@rsandor Updated functional test to check this 👍 |
Contributor
|
LGTM |
| type: Number, | ||
| required: true | ||
| }, | ||
| ownerUsername: { |
Contributor
There was a problem hiding this comment.
this needs db migration right?
Contributor
|
Looking good, you added a new required field so we need to run a db migration right |
Contributor
Author
|
No db migration needed. It'll all eventually work. This is just for reporting, whenever an update happens it'll have this field. |
Contributor
|
@Myztiq do you query for NaviEntry? If you do I think mongoose will not return anything that does not fit the schema? |
Contributor
Author
|
@anandkumarpatel Nope, we only upsert to my knowledge. So we don't have to worry about this. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ownerUsername to the naviEntry so we can do tracking on this.