Aha guide milestone2#1669
Merged
taylordolan merged 63 commits intomasterfrom Aug 18, 2016
Merged
Conversation
- add blank dockerfile option - add step 3 of milestone 2
…into aha-guide-milestone2
fix padding when help card is active
Member
|
Terminal tab is still visible with all feature flags off |
| 'ace-runnable-dark': !$root.featureFlags.imAfraidOfTheDark,\ | ||
| 'ace-runnable-light': $root.featureFlags.imAfraidOfTheDark\ | ||
| }" | ||
| ng-if = "SMC.page === 'run' && !SMC.showDebugCmd && $root.featureFlags.webToolbar" |
Member
There was a problem hiding this comment.
This feature flag doesn't exist (line 60)
Member
|
"Got It" button is cut off at 440px |
Member
|
iPhone size |
Member
|
iPhone size |
- fix environment view aha guide - fix modal backdrop aha guide - fix next button not being full width - fix aha guide button overlapping add config button
- fix repo select flow - fix aha sidebar - fix popover being cut off
Member
|
Now the web toolbar is always visible |
| ng-class = "{'active': SMC.page === 'terminal'}" | ||
| ng-click = "SMC.page = 'terminal'" | ||
| ng-disabled = "!SMC.instance.containers.models.length" | ||
| ng-if = "$root.featureFlags.configTerminal" |
Member
There was a problem hiding this comment.
This feature flag doesn't exist (line 35)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/drawings/d/1sd5BtnYK7bp2iDXmTmU82rWr0Z_oZx8pyhU-YTxneKY/edit