SAN-4781 Payments Integration #1678
Conversation
|
The latest push to PR-1678 is running on SAN-4781-payments-integration-v3-runnable-angular |
|
The latest push to PR-1678 is running on SAN-4781-payments-integration-v3-angular-unit |
|
|
||
| $scope.getBillingDate = function (invoice) { | ||
| return moment(invoice.period_end * 1000).format('M/D/YYYY'); | ||
| return moment(invoice.periodEnd).format('M/D/YYYY'); |
There was a problem hiding this comment.
if we have now non US customers (and I think we have customers from Ireland) I would suggest to change M/D/YYYY format. For most people outside of US this one can be super confusing.
I would do something like Aug 25, 2016 - that would be unambiguous
…' into SAN-4781-payments-integration-v3
| link: function ($scope) { | ||
| $scope.currentOrg = currentOrg; | ||
| $scope.hasUpdated = false; | ||
| $rootScope.$on('updated-payment-method', function () { |
There was a problem hiding this comment.
You need to $off this on $scope.destroy.
There was a problem hiding this comment.
well, call the unregister function
There was a problem hiding this comment.
Also, does this need to listen for this on the rootscope?
|
Code LGTM. Doing more E2E testing. |
|
Super minor: If I add a payment method to an org that's in an active period already, this shows up. I would necessarily fix this since there should be no state in which an org is in this state, but just to point it out.
|
|
I think Stripe creates these for test accounts. Not sure if we want to filter them?
|
|
Ehh, I don't care about people being in weird states seeing odd things. It's not a state that should be possible to be in. Would you like me to filter those out? |
…oad by clearing the cache when it's closed.
|
LGTM |
|
LGTM |
|
LGTM |
|
I know I LGTM this PR, but can we confirm this is expected behavior (still seems weird to me): |
|
That is tracked in a bug :) |
Actually hooked up with real API routes, got saving and updating of CC working.
My apologies, this has kind of evolved and now encompasses everything needed to get payments pushed to production. I'll freeze this branch so it can be reviewed and make any new changes in a v4 branch.