Fix bug where payment method wouldn't refresh until after page load#1683
Merged
Fix bug where payment method wouldn't refresh until after page load#1683
Conversation
…o we know it's been refreshed in the UI.
|
The latest push to PR-1683 has failed to build. Check out the logs SAN-4839-refresh-cc-information-runnable-angular |
|
The latest push to PR-1683 is running on SAN-4839-refresh-cc-information-runnable-angular |
|
The latest push to PR-1683 is running on SAN-4839-refresh-cc-information-angular-unit |
added 2 commits
August 24, 2016 12:05
…pdate hasPaymentMethod property)
Member
|
Tested with local and gamma, looks good! 👍 |
| .then(function (res) { | ||
| return savePaymentMethod(res.id); | ||
| }) | ||
| .then(function () { |
Contributor
There was a problem hiding this comment.
how does fetching whitelist affect payment method?
Contributor
Author
There was a problem hiding this comment.
When they put in a payment method the whitelist object needs to be refreshed because the whitelist object contains a boolean flag "hasPaymentMethod"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now update the whitelists model when the payment method is added so we know it's been refreshed in the UI.