Conversation
taylordolan
reviewed
Apr 19, 2017
| spellcheck = "false" | ||
| type = "url" | ||
| ) | ||
| small.grid-block.padding-xxs.small Add the URL for the registry you use. This could be from Docker Hub, or a private registry. |
Member
There was a problem hiding this comment.
The spacing would be more even if you removed the padding-bottom from this element.
Member
There was a problem hiding this comment.
Also I don't think you need the comma after "Docker Hub".
Member
Author
There was a problem hiding this comment.
That's the default for all .small text under form inputs, I'm reluctant to change that right now.
| spellcheck = "false" | ||
| type = "password" | ||
| ) | ||
| footer.margin-top-sm.padding-sm.grid-block.justify-right.footer |
Member
There was a problem hiding this comment.
Did you decide against the "Cancel" or "Back" button here?
| @@ -0,0 +1,78 @@ | |||
| section.label-description | |||
| .label-col Private Registry | |||
| .small.text-gray If you push your images to a private registry, you can safely store your credientials to use those images on Runnable.  | |||
Member
There was a problem hiding this comment.
credientials -> credentials
taylordolan
approved these changes
Apr 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/drawings/d/1k8zWNvwigpeoo3iAtkGknNj_O9DWQCoILEDwSR9jvdc/edit