San 5818 rerun containers#2200
Merged
henrymollman merged 6 commits intomasterfrom May 2, 2017
Merged
Conversation
damienrunnable
approved these changes
Apr 25, 2017
Contributor
damienrunnable
left a comment
damienrunnable
left a comment
There was a problem hiding this comment.
LGTM per discussion.
| }, | ||
| redeployCluster: function () { | ||
| $rootScope.$broadcast('close-popovers'); | ||
| loading('main', true); |
Contributor
There was a problem hiding this comment.
Do we have a finally or equivalent to turn this back to false?
Contributor
There was a problem hiding this comment.
That exists, loading('main', false)
Myztiq
reviewed
Apr 28, 2017
| .catch(errs.handler) | ||
| .finally(function () { | ||
| loading('main', false); | ||
| return $state.go('base.instances.instance', { |
Contributor
There was a problem hiding this comment.
Is there a reason we are navigating the user?
Contributor
Author
There was a problem hiding this comment.
The rebuild without cache method reloads the state for the user - I thought that the experience should be mirrored here, unless there is a reason not to.
Contributor
There was a problem hiding this comment.
That's fine, I thought it does it by default though, we listen to the events.
Myztiq
approved these changes
Apr 28, 2017
Contributor
Myztiq
left a comment
Myztiq
left a comment
There was a problem hiding this comment.
👍 one question, but it's fine
henrymollman
force-pushed
the
SAN-5818-rerun-containers
branch
from
55ddc29 to
9927015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a way for users to redeploy a test cluster, rerunning tests without rebuilding the test container but still rebuilding the dependencies.