Making instance routing awesome-saucesome #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and even using the local storage to record the last instance.
Fixing Tests, Creating service for fetching instances
Contributor
There was a problem hiding this comment.
Are we sure "Home" is the name we want to use here? This is a smart redirect.
Contributor
|
I'd also like some tests on Make sure you merge in master for the latest coverage limits |
Fixing some things that had issues, found during testing
Conflicts: test/unit/directives/directiveEditRepoCommit.unit.js
SomeKittens
added a commit
that referenced
this pull request
Dec 31, 2014
Making instance routing awesome-saucesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now runnable.io/username will now be responsible for choosing which instance to go to (last loaded), or if none, /new
This is where everything should redirect to when deciding on an instance to go to.