fix(elected-leader): suppress transport echoes and propagate event id#6
Merged
Merged
Conversation
Same echo loop as the SharedWorker hub: when the leader forwards an outbox entry to the transport and the server bounces it back, the event returns through `onTransportMessage` and is broadcast to every tab — including the originating tab — as `source: 'remote'`. Activity feeds double up and any handler keyed on `source === 'remote'` fires for own-sends. - Add a per-instance bounded TTL set of recently-sent ids; drop incoming transport messages whose id matches. - Bonus: `onTransportMessage` was discarding the incoming `id` (`eventId: ''`); now propagates `parsed.id` so subscribers can see the original event id alongside `source: 'remote'`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 10, 2026
joelshejar
added a commit
that referenced
this pull request
May 10, 2026
…-state feat(worker): pong carries visibilityState (unblocks lifecycle e2e #6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onTransportMessageand is broadcast to every tab — including the originating tab — assource: 'remote'.onTransportMessagewas throwing away the incomingid(eventId: ''). Now propagatesparsed.idso subscribers see the original event id alongsidesource: 'remote'.Test plan
pnpm --filter @tabmesh/core exec vitest --run— 93/93 passElectedLeaderHub.ts?hub=electedand shares the same protocol shape.🤖 Generated with Claude Code