Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes two main changes: it removes the unused
Placeholderimport and configuration from the application service provider, and it refactors the notification JavaScript classes to use private fields and provide atoJSONmethod for serializing notification data.Code cleanup and dependency removal:
PlaceholderinAppServiceProvider.php, simplifying the list of translatable components. [1] [2]Notification JavaScript improvements:
FilamentNotification,FilamentNotificationAction,FilamentNotificationActionGroup) innotifications.jsto use private fields (e.g.,_id,_title) instead of public properties, improving encapsulation.toJSONmethod to each notification-related class, enabling proper serialization of notification data before dispatching events. Now, notifications and actions are sent as plain objects rather than class instances.