-
-
Notifications
You must be signed in to change notification settings - Fork 437
Glasgow class 6- Yesna Omar- JavaScript- week 2 #448
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,14 @@ | |
1. the user should be 18 or older | ||
2. the user must be logged in | ||
*/ | ||
function isAcceptableUser(userAge, isLoggedIn) {} | ||
function isAcceptableUser(userAge, isLoggedIn) { | ||
userAge == 18; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, you have this same coding pattern. What does it do? |
||
if(userAge >= 18 && isLoggedIn){ | ||
return true; | ||
}else{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You seem to not have format on save turned on (or it is conflicting with your auto-save?). Could you work with your buddy or a volunteer on Saturday to fix this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am experiencing the same problem even though my format on save option is turned on. I will take a look at it on Saturday to see if I can fix it with volunteers help |
||
return false; | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to apply discount percent based on how much is totalPrice in user cart. | ||
|
@@ -15,26 +22,59 @@ function isAcceptableUser(userAge, isLoggedIn) {} | |
is applieds and 142.5 should be returned) | ||
*/ | ||
|
||
function applyDiscount(totalPrice) {} | ||
function applyDiscount(totalPrice, discount) { | ||
if (totalPrice >200) { | ||
total= totalPrice-(totalPrice*0.1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. total should be defined with |
||
return total; | ||
} else if (totalPrice < 200){ | ||
total=totalPrice-(totalPrice*0.05); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two lines occur twice. Can you see how if you had a new user requirement (for example, to add some rounding), you would need to change your code in 2 places. Could you rewrite this code to make it less verbose? |
||
return total; | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop): | ||
*/ | ||
function printOddNumbers(limit) {} | ||
function printOddNumbers(limit) { | ||
let count = 1; | ||
while(count<=limit){ | ||
if(count %2 == 1){ | ||
console.log(count); | ||
} | ||
count++ | ||
} | ||
|
||
} | ||
|
||
/* | ||
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free! | ||
The function should return the price to be paid once the discount is applied. | ||
*/ | ||
function buyTwoGetTheCheapestFree(price1, price2) {} | ||
function buyTwoGetTheCheapestFree(price1, price2) { | ||
|
||
if (price1>price2) { | ||
return price1; | ||
} else { | ||
return price2; | ||
} | ||
|
||
} | ||
|
||
/* | ||
Complete the function to determine if it is suitable for a person to register based on their age! | ||
- if the person is 12 or younger it should return "You Are Too Young To Register" | ||
- if the person is older than 12 and younger than 90 it should return "You Can Register" | ||
- if the person is 90 or older it should return "You Don't Need To Register" | ||
*/ | ||
function canRegister(age) {} | ||
function canRegister(age) { | ||
if (age <= 12) { | ||
return "You Are Too Young To Register" | ||
} else if(age > 12 && age <90){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need to write age > 12 in this line? What would happen if you remove it? |
||
return "You Can Register" | ||
} else { | ||
return "You Don't Need To Register" | ||
} | ||
} | ||
|
||
/* | ||
Complete the function so that it prints out to the console numbers in reverse order starting at | ||
|
@@ -45,7 +85,15 @@ function canRegister(age) {} | |
) | ||
*/ | ||
|
||
function countReverse(number) {} | ||
function countReverse(number) { | ||
while( number >= 1){ | ||
|
||
console.log(number); | ||
number--; | ||
} | ||
|
||
} | ||
//npm test -- --testPathPattern 2-function-creation | ||
|
||
/* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"scripts": { | ||
"test": "jest" | ||
}, | ||
"jest": { | ||
"jest": { | ||
"projects": [ | ||
{ | ||
"displayName": "mandatory", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me what you think this line does?